aboutsummaryrefslogtreecommitdiff
path: root/scripts/qapi/common.py
diff options
context:
space:
mode:
authorDavid Gibson <david@gibson.dropbear.id.au>2019-02-14 15:39:13 +1100
committerMichael S. Tsirkin <mst@redhat.com>2019-02-21 12:28:41 -0500
commitb218a70e6ae882f52cc339ae965f515a36a9139f (patch)
tree3e3807d8cfca84234ab599774fa6f716495dcc25 /scripts/qapi/common.py
parentf6deb6d95aa7c29fa0047057512060ca720cad22 (diff)
downloadqemu-b218a70e6ae882f52cc339ae965f515a36a9139f.zip
qemu-b218a70e6ae882f52cc339ae965f515a36a9139f.tar.gz
qemu-b218a70e6ae882f52cc339ae965f515a36a9139f.tar.bz2
virtio-balloon: Corrections to address verification
The virtio-balloon device's verification of the address given to it by the guest has a number of faults: * The addresses here are guest physical addresses, which should be 'hwaddr' rather than 'ram_addr_t' (the distinction is admittedly pretty subtle and confusing) * We don't check for section.mr being NULL, which is the main way that memory_region_find() reports basic failures. We really need to check that before looking at any other section fields, because memory_region_find() doesn't initialize them on the failure path * We're passing a length of '1' to memory_region_find(), but really the guest is requesting that we put the entire page into the balloon, so it makes more sense to call it with BALLOON_PAGE_SIZE Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Reviewed-by: David Hildenbrand <david@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Message-Id: <20190214043916.22128-3-david@gibson.dropbear.id.au> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'scripts/qapi/common.py')
0 files changed, 0 insertions, 0 deletions