aboutsummaryrefslogtreecommitdiff
path: root/scripts/qapi-event.py
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2016-03-17 16:48:26 -0600
committerMarkus Armbruster <armbru@redhat.com>2016-03-18 10:29:25 +0100
commit29f6bd15eb8a55ed37b2a443f7275b3d134eb2b2 (patch)
tree9068565d2b4aecbc95680df14473eb1e1a4589ea /scripts/qapi-event.py
parent6741d38ad0f2405a6e999ebc9550801b01aca479 (diff)
downloadqemu-29f6bd15eb8a55ed37b2a443f7275b3d134eb2b2.zip
qemu-29f6bd15eb8a55ed37b2a443f7275b3d134eb2b2.tar.gz
qemu-29f6bd15eb8a55ed37b2a443f7275b3d134eb2b2.tar.bz2
qapi: Assert in places where variants are not handled
We are getting closer to the point where we could use one union as the base or variant type within another union type (as long as there are no collisions between any possible combination of member names allowed across all discriminator choices). But until we get to that point, it is worth asserting that variants are not present in places where we are not prepared to handle them: when exploding a type into a parameter list, we do not expect variants. The qapi.py code is already checking this, via the older check_type() method; but someday we hope to get rid of that and move checking into QAPISchema*.check(). The two asserts added here make sure any refactoring still catches problems, and makes it locally obvious why we can iterate over only type.members without worrying about type.variants. Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <1458254921-17042-2-git-send-email-eblake@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'scripts/qapi-event.py')
-rw-r--r--scripts/qapi-event.py1
1 files changed, 1 insertions, 0 deletions
diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py
index fb579dd..c03cb78 100644
--- a/scripts/qapi-event.py
+++ b/scripts/qapi-event.py
@@ -59,6 +59,7 @@ def gen_event_send(name, arg_type):
name=name)
if arg_type and arg_type.members:
+ assert not arg_type.variants
ret += mcgen('''
qov = qmp_output_visitor_new();
v = qmp_output_get_visitor(qov);