diff options
| author | Mao Zhongyi <maozhongyi@cmss.chinamobile.com> | 2018-11-16 14:33:03 -0600 |
|---|---|---|
| committer | Eric Blake <eblake@redhat.com> | 2018-11-19 10:08:19 -0600 |
| commit | e8d81a61e1b9e28267164f751dee5b9b59444e71 (patch) | |
| tree | 1086e80b29b3a17243fc4b527379d4a9a6b1aa31 /scripts/coccinelle | |
| parent | bf22957309369cf6f642e715ff6c470671920e7e (diff) | |
| download | qemu-e8d81a61e1b9e28267164f751dee5b9b59444e71.zip qemu-e8d81a61e1b9e28267164f751dee5b9b59444e71.tar.gz qemu-e8d81a61e1b9e28267164f751dee5b9b59444e71.tar.bz2 | |
qemu-iotests: convert `pwd` and $(pwd) to $PWD
POSIX requires $PWD to be reliable, and we expect all
shells used by qemu scripts to be relatively close to
POSIX. Thus, it is smarter to avoid forking the pwd
executable for something that is already available in
the environment.
So replace it with the following:
sed -i 's/\(`pwd`\|\$(pwd)\)/$PWD/g' $(git grep -l pwd)
Then delete a pointless line assigning PWD to itself.
Cc: kwolf@redhat.com
Cc: mreitz@redhat.com
Cc: eblake@redhat.com
Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Mao Zhongyi <maozhongyi@cmss.chinamobile.com>
Message-Id: <20181024094051.4470-2-maozhongyi@cmss.chinamobile.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[eblake: touch up commit message, reorder series, tweak a couple more files]
Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'scripts/coccinelle')
| -rw-r--r-- | scripts/coccinelle/tcg_gen_extract.cocci | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/coccinelle/tcg_gen_extract.cocci b/scripts/coccinelle/tcg_gen_extract.cocci index 81e66a3..c10c863 100644 --- a/scripts/coccinelle/tcg_gen_extract.cocci +++ b/scripts/coccinelle/tcg_gen_extract.cocci @@ -17,7 +17,7 @@ // --keep-comments --in-place \ // --use-gitgrep --dir target // -// $ docker run --rm -v `pwd`:`pwd` -w `pwd` philmd/coccinelle \ +// $ docker run --rm -v $PWD:$PWD -w $PWD philmd/coccinelle \ // --macro-file scripts/cocci-macro-file.h \ // --sp-file scripts/coccinelle/tcg_gen_extract.cocci \ // --keep-comments --in-place \ |