aboutsummaryrefslogtreecommitdiff
path: root/scripts/checkpatch.pl
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2014-05-07 09:53:46 +0200
committerLuiz Capitulino <lcapitulino@redhat.com>2014-05-15 14:00:45 -0400
commite2cd0f4fb42b1fae65ad22e8efde9804446e6254 (patch)
treef8ea58b96ee1114f9dd0c45d67d567faec516df3 /scripts/checkpatch.pl
parentcbc95538eda98929d2c5c8ff0d9db9043fcf1ae6 (diff)
downloadqemu-e2cd0f4fb42b1fae65ad22e8efde9804446e6254.zip
qemu-e2cd0f4fb42b1fae65ad22e8efde9804446e6254.tar.gz
qemu-e2cd0f4fb42b1fae65ad22e8efde9804446e6254.tar.bz2
qapi: Replace start_optional()/end_optional() by optional()
Semantics of end_optional() differ subtly from the other end_FOO() callbacks: when start_FOO() succeeds, the matching end_FOO() gets called regardless of what happens in between. end_optional() gets called only when everything in between succeeds as well. Entirely undocumented, like all of the visitor API. The only user of Visitor Callback end_optional() never did anything, and was removed in commit 9f9ab46. I'm about to clean up error handling in the generated visitor code, and end_optional() is in my way. No users mean no test cases, and making non-trivial cleanup transformations without test cases doesn't strike me as a good idea. Drop end_optional(), and rename start_optional() to optional(). We can always go back to a pair of callbacks when we have an actual need. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'scripts/checkpatch.pl')
0 files changed, 0 insertions, 0 deletions