aboutsummaryrefslogtreecommitdiff
path: root/qom
diff options
context:
space:
mode:
authorIgor Mammedov <imammedo@redhat.com>2016-06-09 19:11:02 +0200
committerEduardo Habkost <ehabkost@redhat.com>2016-07-07 15:25:05 -0300
commit09f71b054a95161950a03fafc9023637929bd404 (patch)
treedea984736d97ae43279b0d5f6020b184585171f7 /qom
parent62a48a2a5798425997152dea3fc48708f9116c04 (diff)
downloadqemu-09f71b054a95161950a03fafc9023637929bd404.zip
qemu-09f71b054a95161950a03fafc9023637929bd404.tar.gz
qemu-09f71b054a95161950a03fafc9023637929bd404.tar.bz2
arm: virt: Parse cpu_model only once
Considering that features are converted to global properties and global properties are automatically applied to every new instance of created CPU (at object_new() time), there is no point in parsing cpu_model string every time a CPU created. So move parsing outside CPU creation loop and do it only once. Parsing also should be done before any CPU is created so that features would affect the first CPU a well. Signed-off-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Diffstat (limited to 'qom')
-rw-r--r--qom/cpu.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/qom/cpu.c b/qom/cpu.c
index 2a0d9fe..f884a66 100644
--- a/qom/cpu.c
+++ b/qom/cpu.c
@@ -296,7 +296,6 @@ static void cpu_common_parse_features(const char *typename, char *features,
* call it only once, so we can remove this check (or change it
* to assert(!cpu_globals_initialized).
* Current callers of ->parse_features() are:
- * - machvirt_init()
* - cpu_generic_init()
* - cpu_x86_create()
*/