aboutsummaryrefslogtreecommitdiff
path: root/qom/object.c
diff options
context:
space:
mode:
authorEduardo Habkost <ehabkost@redhat.com>2020-12-15 17:41:33 -0500
committerPaolo Bonzini <pbonzini@redhat.com>2021-01-02 21:03:09 +0100
commit63f957ac96eba545ef60abebfc6741d06fd99ade (patch)
tree3edf4b22984ad54d61eafe678c994045d606d72b /qom/object.c
parent08bdf5d44f999c92399ff73df00f2ea2c7ee04bd (diff)
downloadqemu-63f957ac96eba545ef60abebfc6741d06fd99ade.zip
qemu-63f957ac96eba545ef60abebfc6741d06fd99ade.tar.gz
qemu-63f957ac96eba545ef60abebfc6741d06fd99ade.tar.bz2
qom: Assert that objects being destroyed have no parent
QOM reference counting bugs are often hard to detect, but there's one kind of bug that's easier: if we are freeing an object but is still attached to a parent, it means the reference count is wrong (because the parent always hold a reference to their children). Add an assertion to make sure we detect those cases. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> Message-Id: <20201215224133.3545901-3-ehabkost@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'qom/object.c')
-rw-r--r--qom/object.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/qom/object.c b/qom/object.c
index 5cd43fe..2fa0119 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -685,6 +685,7 @@ static void object_finalize(void *data)
object_deinit(obj, ti);
g_assert(obj->ref == 0);
+ g_assert(obj->parent == NULL);
if (obj->free) {
obj->free(obj);
}