diff options
| author | Eric Blake <eblake@redhat.com> | 2017-11-17 10:47:47 -0600 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2017-11-17 18:21:01 +0100 |
| commit | 4096974e1885913dfe2931863be47bd35b266521 (patch) | |
| tree | d302d6c3ae11cd2197ff281a37cbf252f8d28942 /qobject | |
| parent | 3590cd0f045a5ba8ab40815ba887cbb2b71f0af9 (diff) | |
| download | qemu-4096974e1885913dfe2931863be47bd35b266521.zip qemu-4096974e1885913dfe2931863be47bd35b266521.tar.gz qemu-4096974e1885913dfe2931863be47bd35b266521.tar.bz2 | |
qcow2: fix image corruption on commit with persistent bitmap
If an image contains persistent bitmaps, we cannot use the
fast path of bdrv_make_empty() to clear the image during
qemu-img commit, because that will lose the clusters related
to the bitmaps.
Also leave a comment in qcow2_read_extensions to remind future
feature additions to think about fast-path removal, since we
just barely fixed the same bug for LUKS encryption.
It's a pain that qemu-img has not yet been taught to manipulate,
or even at a very minimum display, information about persistent
bitmaps; instead, we have to use QMP commands. It's also a
pain that only qeury-block and x-debug-block-dirty-bitmap-sha256
will allow bitmap introspection; but the former requires the
node to be hooked to a block device, and the latter is experimental.
Signed-off-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'qobject')
0 files changed, 0 insertions, 0 deletions