diff options
author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2017-08-25 12:59:05 +0200 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2017-09-04 13:09:11 +0200 |
commit | d9eba57a6ad6d8fe8cf11bdd8345bbda66deb6d9 (patch) | |
tree | d317b4e9abf09de808cd4fdd1bfb47c4dbc30dc9 /qobject | |
parent | 60cc2eb7afd40b9cbaa35a5e0b54f365ac6e49f1 (diff) | |
download | qemu-d9eba57a6ad6d8fe8cf11bdd8345bbda66deb6d9.zip qemu-d9eba57a6ad6d8fe8cf11bdd8345bbda66deb6d9.tar.gz qemu-d9eba57a6ad6d8fe8cf11bdd8345bbda66deb6d9.tar.bz2 |
qlit: make qlit_equal_qobject return a bool
Make it more obvious about the expected return values.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20170825105913.4060-7-marcandre.lureau@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'qobject')
-rw-r--r-- | qobject/qlit.c | 18 |
1 files changed, 9 insertions, 9 deletions
diff --git a/qobject/qlit.c b/qobject/qlit.c index 0c41018..a2975be 100644 --- a/qobject/qlit.c +++ b/qobject/qlit.c @@ -21,19 +21,19 @@ typedef struct QListCompareHelper { int index; QLitObject *objs; - int result; + bool result; } QListCompareHelper; static void compare_helper(QObject *obj, void *opaque) { QListCompareHelper *helper = opaque; - if (helper->result == 0) { + if (!helper->result) { return; } if (helper->objs[helper->index].type == QTYPE_NONE) { - helper->result = 0; + helper->result = false; return; } @@ -41,12 +41,12 @@ static void compare_helper(QObject *obj, void *opaque) qlit_equal_qobject(&helper->objs[helper->index++], obj); } -int qlit_equal_qobject(QLitObject *lhs, QObject *rhs) +bool qlit_equal_qobject(QLitObject *lhs, QObject *rhs) { int64_t val; if (!rhs || lhs->type != qobject_type(rhs)) { - return 0; + return false; } switch (lhs->type) { @@ -64,18 +64,18 @@ int qlit_equal_qobject(QLitObject *lhs, QObject *rhs) lhs->value.qdict[i].key); if (!qlit_equal_qobject(&lhs->value.qdict[i].value, obj)) { - return 0; + return false; } } - return 1; + return true; } case QTYPE_QLIST: { QListCompareHelper helper; helper.index = 0; helper.objs = lhs->value.qlist; - helper.result = 1; + helper.result = true; qlist_iter(qobject_to_qlist(rhs), compare_helper, &helper); @@ -85,5 +85,5 @@ int qlit_equal_qobject(QLitObject *lhs, QObject *rhs) break; } - return 0; + return false; } |