diff options
| author | Markus Armbruster <armbru@redhat.com> | 2020-06-30 11:03:33 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2020-07-02 06:25:29 +0200 |
| commit | b368123dd9979e8840b6c98ff69722e7bf1da54d (patch) | |
| tree | 87dca70ff1f7bab5b129c5f80a3b6adf110a5fa3 /qga | |
| parent | 14963c34b9901abee6cc91d1831841b2c20511c3 (diff) | |
| download | qemu-b368123dd9979e8840b6c98ff69722e7bf1da54d.zip qemu-b368123dd9979e8840b6c98ff69722e7bf1da54d.tar.gz qemu-b368123dd9979e8840b6c98ff69722e7bf1da54d.tar.bz2 | |
qga: Plug unlikely memory leak in guest-set-memory-blocks
transfer_memory_block() leaks an Error object when reading file
/sys/devices/system/memory/memory<INDEX>/state fails with errno other
than ENOENT, and @sys2memblk is false, i.e. when the state file exists
but cannot be read (seems quite unlikely), and this is
guest-set-memory-blocks, not guest-get-memory-blocks.
Plug the leak.
Fixes: bd240fca42d5f072fb758a71720d9de9990ac553
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: Hailiang Zhang <zhang.zhanghailiang@huawei.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: zhanghailiang <zhang.zhanghailiang@huawei.com>
Message-Id: <20200630090351.1247703-9-armbru@redhat.com>
Diffstat (limited to 'qga')
| -rw-r--r-- | qga/commands-posix.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/qga/commands-posix.c b/qga/commands-posix.c index ae1348d..cdbeb59 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -2421,6 +2421,7 @@ static void transfer_memory_block(GuestMemoryBlock *mem_blk, bool sys2memblk, if (sys2memblk) { error_propagate(errp, local_err); } else { + error_free(local_err); result->response = GUEST_MEMORY_BLOCK_RESPONSE_TYPE_OPERATION_FAILED; } |