diff options
| author | Prasad J Pandit <pjp@fedoraproject.org> | 2018-06-13 11:46:57 +0530 |
|---|---|---|
| committer | Michael Roth <mdroth@linux.vnet.ibm.com> | 2018-07-03 10:58:06 -0500 |
| commit | 141b197408ab398c4f474ac1a728ab316e921f2b (patch) | |
| tree | 524055e648e01ad0e02cee0c6f1d1fe855a771bb /qga | |
| parent | 65650f0182c11a000d488a3b8e8e6ad071853f31 (diff) | |
| download | qemu-141b197408ab398c4f474ac1a728ab316e921f2b.zip qemu-141b197408ab398c4f474ac1a728ab316e921f2b.tar.gz qemu-141b197408ab398c4f474ac1a728ab316e921f2b.tar.bz2 | |
qga: check bytes count read by guest-file-read
While reading file content via 'guest-file-read' command,
'qmp_guest_file_read' routine allocates buffer of count+1
bytes. It could overflow for large values of 'count'.
Add check to avoid it.
Reported-by: Fakhri Zulkifli <mohdfakhrizulkifli@gmail.com>
Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org>
Cc: qemu-stable@nongnu.org
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Diffstat (limited to 'qga')
| -rw-r--r-- | qga/commands-posix.c | 2 | ||||
| -rw-r--r-- | qga/commands-win32.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 594d21e..9284e71 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -458,7 +458,7 @@ struct GuestFileRead *qmp_guest_file_read(int64_t handle, bool has_count, if (!has_count) { count = QGA_READ_COUNT_DEFAULT; - } else if (count < 0) { + } else if (count < 0 || count >= UINT32_MAX) { error_setg(errp, "value '%" PRId64 "' is invalid for argument count", count); return NULL; diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 70ee537..73f31fa 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -318,7 +318,7 @@ GuestFileRead *qmp_guest_file_read(int64_t handle, bool has_count, } if (!has_count) { count = QGA_READ_COUNT_DEFAULT; - } else if (count < 0) { + } else if (count < 0 || count >= UINT32_MAX) { error_setg(errp, "value '%" PRId64 "' is invalid for argument count", count); return NULL; |