diff options
| author | Kevin Wolf <kwolf@redhat.com> | 2020-04-16 17:26:06 +0200 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2020-04-30 17:51:07 +0200 |
| commit | eaae29ef89d498d0eac553c77b554f310a47f809 (patch) | |
| tree | 89b54cf0c904c6b2681ae9e500b0f8fdb05556b2 /qemu-storage-daemon.c | |
| parent | d6a5beeb2bbf4f5ce6e6396051fb4c5fcced56a4 (diff) | |
| download | qemu-eaae29ef89d498d0eac553c77b554f310a47f809.zip qemu-eaae29ef89d498d0eac553c77b554f310a47f809.tar.gz qemu-eaae29ef89d498d0eac553c77b554f310a47f809.tar.bz2 | |
qemu-storage-daemon: Fix non-string --object properties
After processing the option string with the keyval parser, we get a
QDict that contains only strings. This QDict must be fed to a keyval
visitor which converts the strings into the right data types.
qmp_object_add(), however, uses the normal QObject input visitor, which
expects a QDict where all properties already have the QType that matches
the data type required by the QOM object type.
Change the --object implementation in qemu-storage-daemon so that it
doesn't call qmp_object_add(), but calls user_creatable_add_dict()
directly instead and pass it a new keyval boolean that decides which
visitor must be used.
Reported-by: Coiby Xu <coiby.xu@gmail.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'qemu-storage-daemon.c')
| -rw-r--r-- | qemu-storage-daemon.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/qemu-storage-daemon.c b/qemu-storage-daemon.c index dd12897..9e7adfe 100644 --- a/qemu-storage-daemon.c +++ b/qemu-storage-daemon.c @@ -278,7 +278,6 @@ static void process_options(int argc, char *argv[]) QemuOpts *opts; const char *type; QDict *args; - QObject *ret_data = NULL; /* FIXME The keyval parser rejects 'help' arguments, so we must * unconditionall try QemuOpts first. */ @@ -291,9 +290,8 @@ static void process_options(int argc, char *argv[]) qemu_opts_del(opts); args = keyval_parse(optarg, "qom-type", &error_fatal); - qmp_object_add(args, &ret_data, &error_fatal); + user_creatable_add_dict(args, true, &error_fatal); qobject_unref(args); - qobject_unref(ret_data); break; } default: |