diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2016-06-10 16:00:36 +0100 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2016-06-16 18:39:04 +0200 |
| commit | 773dce3c7286a66c37f7b07994177faf7046bfa8 (patch) | |
| tree | 154ca1ab8e3f73b6a1bdfae3eb622783c5b849f8 /qemu-nbd.c | |
| parent | 0fb233125471b0c001b04df9e1b38c752ba002ee (diff) | |
| download | qemu-773dce3c7286a66c37f7b07994177faf7046bfa8.zip qemu-773dce3c7286a66c37f7b07994177faf7046bfa8.tar.gz qemu-773dce3c7286a66c37f7b07994177faf7046bfa8.tar.bz2 | |
nbd: Don't use *_to_cpup() functions
The *_to_cpup() functions are not very useful, as they simply do
a pointer dereference and then a *_to_cpu(). Instead use either:
* ld*_*_p(), if the data is at an address that might not be
correctly aligned for the load
* a local dereference and *_to_cpu(), if the pointer is
the correct type and known to be correctly aligned
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <1465570836-22211-1-git-send-email-peter.maydell@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'qemu-nbd.c')
| -rw-r--r-- | qemu-nbd.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -154,8 +154,8 @@ static void read_partition(uint8_t *p, struct partition_record *r) r->end_cylinder = p[7] | ((p[6] << 2) & 0x300); r->end_sector = p[6] & 0x3f; - r->start_sector_abs = le32_to_cpup((uint32_t *)(p + 8)); - r->nb_sectors_abs = le32_to_cpup((uint32_t *)(p + 12)); + r->start_sector_abs = ldl_le_p(p + 8); + r->nb_sectors_abs = ldl_le_p(p + 12); } static int find_partition(BlockBackend *blk, int partition, |