aboutsummaryrefslogtreecommitdiff
path: root/qemu-nbd.c
diff options
context:
space:
mode:
authorDenis V. Lunev <den@openvz.org>2023-09-06 11:32:03 +0200
committerEric Blake <eblake@redhat.com>2023-09-07 20:32:11 -0500
commitb4bbdf51e3af2ac7a8dd269bcdadd11523978dda (patch)
treeab908d3d7a732952b7d81db126fdb34b55cc439c /qemu-nbd.c
parent522a9b94e0f8a1f89f1660a46121ab0d0eae3593 (diff)
downloadqemu-b4bbdf51e3af2ac7a8dd269bcdadd11523978dda.zip
qemu-b4bbdf51e3af2ac7a8dd269bcdadd11523978dda.tar.gz
qemu-b4bbdf51e3af2ac7a8dd269bcdadd11523978dda.tar.bz2
qemu-nbd: improve error message for dup2 error
This error happens if we are not able to close the pipe to the parent (to trace errors in the child process) and assign stderr to /dev/null as required by the daemonizing convention. Signed-off-by: Denis V. Lunev <den@openvz.org> Suggested-by: Eric Blake <eblake@redhat.com> CC: Eric Blake <eblake@redhat.com> CC: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru> Message-ID: <20230906093210.339585-2-den@openvz.org> Reviewed-by: Eric Blake <eblake@redhat.com> [eblake: commit message grammar] Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'qemu-nbd.c')
-rw-r--r--qemu-nbd.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/qemu-nbd.c b/qemu-nbd.c
index b47459f..e248006 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -324,7 +324,7 @@ static void *nbd_client_thread(void *arg)
} else {
/* Close stderr so that the qemu-nbd process exits. */
if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
- error_report("Could not set stderr to /dev/null: %s",
+ error_report("Could not release pipe to parent: %s",
strerror(errno));
exit(EXIT_FAILURE);
}
@@ -1181,7 +1181,7 @@ int main(int argc, char **argv)
if (fork_process) {
if (dup2(STDOUT_FILENO, STDERR_FILENO) < 0) {
- error_report("Could not set stderr to /dev/null: %s",
+ error_report("Could not release pipe to parent: %s",
strerror(errno));
exit(EXIT_FAILURE);
}