aboutsummaryrefslogtreecommitdiff
path: root/qemu-img.c
diff options
context:
space:
mode:
authorDaniel P. Berrange <berrange@redhat.com>2017-05-15 17:47:10 +0100
committerMax Reitz <mreitz@redhat.com>2017-05-29 15:39:53 +0200
commitea204ddac7340bfda60cb0b388dbc3ffd77e8be0 (patch)
treefcbb8943830dd46d8e3b87a4c2f1dd3bc3bfe1ec /qemu-img.c
parent83d4bf943e09cbcb011e255c872724e95fe4856e (diff)
downloadqemu-ea204ddac7340bfda60cb0b388dbc3ffd77e8be0.zip
qemu-ea204ddac7340bfda60cb0b388dbc3ffd77e8be0.tar.gz
qemu-ea204ddac7340bfda60cb0b388dbc3ffd77e8be0.tar.bz2
qemu-img: fix --image-opts usage with dd command
The --image-opts flag can only be used to affect the parsing of the source image. The target image has to be specified in the traditional style regardless, since it needs to be passed to the bdrv_create() API which does not support the new style opts. Reviewed-by: Fam Zheng <famz@redhat.com> Reviewed-by: Max Reitz <mreitz@redhat.com> Signed-off-by: Daniel P. Berrange <berrange@redhat.com> Message-id: 20170515164712.6643-3-berrange@redhat.com Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'qemu-img.c')
-rw-r--r--qemu-img.c9
1 files changed, 7 insertions, 2 deletions
diff --git a/qemu-img.c b/qemu-img.c
index 181f499..4dc1d56 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -4316,8 +4316,13 @@ static int img_dd(int argc, char **argv)
goto out;
}
- blk2 = img_open(image_opts, out.filename, out_fmt, BDRV_O_RDWR,
- false, false, false);
+ /* TODO, we can't honour --image-opts for the target,
+ * since it needs to be given in a format compatible
+ * with the bdrv_create() call above which does not
+ * support image-opts style.
+ */
+ blk2 = img_open_file(out.filename, out_fmt, BDRV_O_RDWR,
+ false, false, false);
if (!blk2) {
ret = -1;