diff options
| author | Cornelia Huck <cohuck@redhat.com> | 2021-02-16 12:18:30 +0100 |
|---|---|---|
| committer | Cornelia Huck <cohuck@redhat.com> | 2021-03-04 11:23:35 +0100 |
| commit | 151fcdfd628a396845b275831e920ddbc10a9f18 (patch) | |
| tree | a15d33dd0acced19628020de036bfb54da123f4c /qemu-img.c | |
| parent | 403af209db8c030ed1e000640cd3cd80c6882883 (diff) | |
| download | qemu-151fcdfd628a396845b275831e920ddbc10a9f18.zip qemu-151fcdfd628a396845b275831e920ddbc10a9f18.tar.gz qemu-151fcdfd628a396845b275831e920ddbc10a9f18.tar.bz2 | |
virtio-ccw: commands on revision-less devices
The virtio standard specifies that any non-transitional device must
reject commands prior to revision setting (which we do). Devices
that are transitional need to assume revision 0 (legacy) if the
driver sends a non-revision-setting command first in order to
support legacy drivers. We neglected to do the latter.
Fortunately, nearly everything worked as intended anyway; the only
problem was not properly rejecting revision setting after some other
command had been issued. Easy to fix by setting revision to 0 if
we see a non-revision command on a legacy-capable revision-less
device.
Found by code inspection, not observed in the wild.
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Halil Pasic <pasic@linux.ibm.com>
Message-Id: <20210216111830.1087847-1-cohuck@redhat.com>
Diffstat (limited to 'qemu-img.c')
0 files changed, 0 insertions, 0 deletions