diff options
| author | John Snow <jsnow@redhat.com> | 2016-11-14 11:15:54 -0500 |
|---|---|---|
| committer | John Snow <jsnow@redhat.com> | 2016-11-14 11:15:54 -0500 |
| commit | c47ee043dc2cc85da710e87524144a720598c096 (patch) | |
| tree | 39dfc4c240343a6546903218ab472109bf7e4858 /qemu-char.c | |
| parent | ebde93bf9a13f2e0a853eac8fb4f33c9ecd74baf (diff) | |
| download | qemu-c47ee043dc2cc85da710e87524144a720598c096.zip qemu-c47ee043dc2cc85da710e87524144a720598c096.tar.gz qemu-c47ee043dc2cc85da710e87524144a720598c096.tar.bz2 | |
block-backend: Always notify on blk_eject
blk_eject is only used by scsi-disk and atapi, and in both cases we
only attempt to invoke blk_eject if we have a bona-fide change in
tray state.
The "issue" here is that the tray state does not generate a QMP event
unless there is a medium/BDS attached to the device, so if libvirt et al
are waiting for a tray event to occur from an empty-but-closed drive,
software opening that drive will not emit an event and libvirt will
wait forever.
Change this by modifying blk_eject to always emit an event, instead of
conditionally on a "real" backend eject.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1373264
Reported-by: Peter Krempa <pkrempa@redhat.com>
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Message-id: 1478553214-497-2-git-send-email-jsnow@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'qemu-char.c')
0 files changed, 0 insertions, 0 deletions