aboutsummaryrefslogtreecommitdiff
path: root/qemu-char.c
diff options
context:
space:
mode:
authorOrit Wasserman <owasserm@redhat.com>2012-09-24 13:11:09 +0200
committerAnthony Liguori <aliguori@us.ibm.com>2012-09-25 19:05:56 -0500
commit233aa5c2d1cf4655ffe335025a68cf5454f87dad (patch)
tree8a772e4cd7a5a48d7f4abc49eef1e08e7622e11e /qemu-char.c
parent5db5f44cb4b7f24b9e0efdefc9015e36b7c34881 (diff)
downloadqemu-233aa5c2d1cf4655ffe335025a68cf5454f87dad.zip
qemu-233aa5c2d1cf4655ffe335025a68cf5454f87dad.tar.gz
qemu-233aa5c2d1cf4655ffe335025a68cf5454f87dad.tar.bz2
Fix address handling in inet_nonblocking_connect
getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. To fix this make inet_connect_nonblocking retry connection with a different address. callers on inet_nonblocking_connect register a callback function that will be called when connect opertion completes, in case of failure the fd will have a negative value Signed-off-by: Orit Wasserman <owasserm@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Diffstat (limited to 'qemu-char.c')
-rw-r--r--qemu-char.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/qemu-char.c b/qemu-char.c
index 13b87b5..b082bae 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -2456,7 +2456,7 @@ static CharDriverState *qemu_chr_open_socket(QemuOpts *opts)
if (is_listen) {
fd = inet_listen_opts(opts, 0, NULL);
} else {
- fd = inet_connect_opts(opts, true, NULL, NULL);
+ fd = inet_connect_opts(opts, NULL, NULL, NULL);
}
}
if (fd < 0) {