aboutsummaryrefslogtreecommitdiff
path: root/qapi
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2018-07-03 10:53:30 +0200
committerMarkus Armbruster <armbru@redhat.com>2018-07-03 23:09:49 +0200
commitd621cfe0a177978b17711a712293221294430f53 (patch)
tree214068b47bd8d4abf2f16a073aa2a085cdcada7b /qapi
parent71696cc66ce74a645e68844340e9fb5cfd598cc2 (diff)
downloadqemu-d621cfe0a177978b17711a712293221294430f53.zip
qemu-d621cfe0a177978b17711a712293221294430f53.tar.gz
qemu-d621cfe0a177978b17711a712293221294430f53.tar.bz2
qmp: Document COMMAND_DROPPED design flaw
Events are broadcast to all monitors. If another monitor's client has a command with the same ID in flight, the event will incorrectly claim that command was dropped. This must be fixed before out-of-band execution can graduate from "experimental". Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-Id: <20180703085358.13941-5-armbru@redhat.com>
Diffstat (limited to 'qapi')
-rw-r--r--qapi/misc.json3
1 files changed, 3 insertions, 0 deletions
diff --git a/qapi/misc.json b/qapi/misc.json
index 0446c3e..74cd97f 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -3454,6 +3454,9 @@
# only be dropped when the oob capability is enabled.
#
# @id: The dropped command's "id" field.
+# FIXME Broken by design. Events are broadcast to all monitors. If
+# another monitor's client has a command with the same ID in flight,
+# the event will incorrectly claim that command was dropped.
#
# @reason: The reason why the command is dropped.
#