diff options
| author | Markus Armbruster <armbru@redhat.com> | 2014-05-02 13:26:35 +0200 |
|---|---|---|
| committer | Luiz Capitulino <lcapitulino@redhat.com> | 2014-05-09 09:11:31 -0400 |
| commit | 4af8be1f88dc32447e085469461d02859ca5f2fc (patch) | |
| tree | 367dce49d7a151d2b59572ab8ff2d250f6feb1a3 /qapi | |
| parent | 415168e0c7bda5371a876914d4fdb68c4556f28d (diff) | |
| download | qemu-4af8be1f88dc32447e085469461d02859ca5f2fc.zip qemu-4af8be1f88dc32447e085469461d02859ca5f2fc.tar.gz qemu-4af8be1f88dc32447e085469461d02859ca5f2fc.tar.bz2 | |
qapi: Drop redundant, unclean error_is_set()
do_qmp_dispatch()'s test for qmp_dispatch_check_obj() failure examines
both the return value and the error object. The latter part is
unclean; it works only when do_qmp_dispatch()'s caller passes a
non-null errp argument. That's the case, but it's not locally
obvious. Unclean.
Cleanup would be easy enough, but since the unclean code is also
redundant, let's just drop it.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Diffstat (limited to 'qapi')
| -rw-r--r-- | qapi/qmp-dispatch.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index 141a376..187af56 100644 --- a/qapi/qmp-dispatch.c +++ b/qapi/qmp-dispatch.c @@ -67,9 +67,8 @@ static QObject *do_qmp_dispatch(QObject *request, Error **errp) QmpCommand *cmd; QObject *ret = NULL; - dict = qmp_dispatch_check_obj(request, errp); - if (!dict || error_is_set(errp)) { + if (!dict) { return NULL; } |