diff options
| author | Fabiano Rosas <farosas@suse.de> | 2023-09-18 14:28:17 -0300 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2023-09-27 13:58:02 -0400 |
| commit | 639decf529793fc544c8055b82be8abe77fa48fa (patch) | |
| tree | fd37e8a1c72201ce869c476665bf10144079ec1d /qapi/qobject-input-visitor.c | |
| parent | 28a8347281e24c2e7bba6d3301472eda41d4c096 (diff) | |
| download | qemu-639decf529793fc544c8055b82be8abe77fa48fa.zip qemu-639decf529793fc544c8055b82be8abe77fa48fa.tar.gz qemu-639decf529793fc544c8055b82be8abe77fa48fa.tar.bz2 | |
migration: Fix possible races when shutting down the return path
We cannot call qemu_file_shutdown() on the return path file without
taking the file lock. The return path thread could be running it's
cleanup code and have just cleared the from_dst_file pointer.
Checking ms->to_dst_file for errors could also race with
migrate_fd_cleanup() which clears the to_dst_file pointer.
Protect both accesses by taking the file lock.
This was caught by inspection, it should be rare, but the next patches
will start calling this code from other places, so let's do the
correct thing.
Reviewed-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20230918172822.19052-4-farosas@suse.de>
Diffstat (limited to 'qapi/qobject-input-visitor.c')
0 files changed, 0 insertions, 0 deletions