diff options
| author | Markus Armbruster <armbru@redhat.com> | 2015-09-16 13:06:26 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2015-09-21 09:56:49 +0200 |
| commit | b8a98326d565516bfcaa6582781605d167471b48 (patch) | |
| tree | e494cb395596efdcf805715c132af958f33429f0 /qapi-schema.json | |
| parent | 6eb3937e9b20319e1c4f4d53e906fda8f5ccda10 (diff) | |
| download | qemu-b8a98326d565516bfcaa6582781605d167471b48.zip qemu-b8a98326d565516bfcaa6582781605d167471b48.tar.gz qemu-b8a98326d565516bfcaa6582781605d167471b48.tar.bz2 | |
qapi-schema: Fix up misleading specification of netdev_add
It doesn't take a 'props' argument, let alone one in the format
"NAME=VALUE,..."
The bogus arguments specification doesn't matter due to 'gen': false.
Clean it up to be incomplete rather than wrong, and document the
incompleteness.
While there, improve netdev_add usage example in the manual: add a
device option to show how it's done.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Message-Id: <1442401589-24189-24-git-send-email-armbru@redhat.com>
Diffstat (limited to 'qapi-schema.json')
| -rw-r--r-- | qapi-schema.json | 13 |
1 files changed, 7 insertions, 6 deletions
diff --git a/qapi-schema.json b/qapi-schema.json index 756ed9e..3ff9fec 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -2079,11 +2079,12 @@ # # @id: the name of the new network backend # -# @props: #optional a list of properties to be passed to the backend in -# the format 'name=value', like 'ifname=tap0,script=no' +# Additional arguments depend on the type. # -# Notes: The semantics of @props is not well defined. Future commands will be -# introduced that provide stronger typing for backend creation. +# TODO This command effectively bypasses QAPI completely due to its +# "additional arguments" business. It shouldn't have been added to +# the schema in this form. It should be qapified properly, or +# replaced by a properly qapified command. # # Since: 0.14.0 # @@ -2091,8 +2092,8 @@ # If @type is not a valid network backend, DeviceNotFound ## { 'command': 'netdev_add', - 'data': {'type': 'str', 'id': 'str', '*props': '**'}, - 'gen': false } + 'data': {'type': 'str', 'id': 'str'}, + 'gen': false } # so we can get the additional arguments ## # @netdev_del: |