aboutsummaryrefslogtreecommitdiff
path: root/python
diff options
context:
space:
mode:
authorJohn Snow <jsnow@redhat.com>2022-01-31 23:11:31 -0500
committerJohn Snow <jsnow@redhat.com>2022-02-02 14:12:22 -0500
commitfa73e6e4ca1a93c5bbf9d05fb2a25736ab810b35 (patch)
tree1454f202f038d156e86ffa7e16bd65d4da5e1494 /python
parent47cc1a3655135b89fa75c2824fbddd29df874612 (diff)
downloadqemu-fa73e6e4ca1a93c5bbf9d05fb2a25736ab810b35.zip
qemu-fa73e6e4ca1a93c5bbf9d05fb2a25736ab810b35.tar.gz
qemu-fa73e6e4ca1a93c5bbf9d05fb2a25736ab810b35.tar.bz2
python/aqmp: Fix negotiation with pre-"oob" QEMU
QEMU versions prior to the "oob" capability *also* can't accept the "enable" keyword argument at all. Fix the handshake process with older QEMU versions. Signed-off-by: John Snow <jsnow@redhat.com> Reviewed-by: Hanna Reitz <hreitz@redhat.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Message-id: 20220201041134.1237016-2-jsnow@redhat.com Signed-off-by: John Snow <jsnow@redhat.com>
Diffstat (limited to 'python')
-rw-r--r--python/qemu/aqmp/qmp_client.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/python/qemu/aqmp/qmp_client.py b/python/qemu/aqmp/qmp_client.py
index f1a845c..90a8737 100644
--- a/python/qemu/aqmp/qmp_client.py
+++ b/python/qemu/aqmp/qmp_client.py
@@ -292,9 +292,9 @@ class QMPClient(AsyncProtocol[Message], Events):
"""
self.logger.debug("Negotiating capabilities ...")
- arguments: Dict[str, List[str]] = {'enable': []}
+ arguments: Dict[str, List[str]] = {}
if self._greeting and 'oob' in self._greeting.QMP.capabilities:
- arguments['enable'].append('oob')
+ arguments.setdefault('enable', []).append('oob')
msg = self.make_execute_msg('qmp_capabilities', arguments=arguments)
# It's not safe to use execute() here, because the reader/writers