diff options
author | Hanna Reitz <hreitz@redhat.com> | 2021-10-06 17:19:28 +0200 |
---|---|---|
committer | Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> | 2021-10-07 10:40:48 +0200 |
commit | d431131439f228626aedc6d211c73b2a3616d5e1 (patch) | |
tree | a5f35cd4b4a00839f999404ff569584a60d7cea1 /python/setup.py | |
parent | a9515df4d66da34cbc2938e4c1f46015fc74ff93 (diff) | |
download | qemu-d431131439f228626aedc6d211c73b2a3616d5e1.zip qemu-d431131439f228626aedc6d211c73b2a3616d5e1.tar.gz qemu-d431131439f228626aedc6d211c73b2a3616d5e1.tar.bz2 |
job: Context changes in job_completed_txn_abort()
Finalizing the job may cause its AioContext to change. This is noted by
job_exit(), which points at job_txn_apply() to take this fact into
account.
However, job_completed() does not necessarily invoke job_txn_apply()
(through job_completed_txn_success()), but potentially also
job_completed_txn_abort(). The latter stores the context in a local
variable, and so always acquires the same context at its end that it has
released in the beginning -- which may be a different context from the
one that job_exit() releases at its end. If it is different, qemu
aborts ("qemu_mutex_unlock_impl: Operation not permitted").
Drop the local @outer_ctx variable from job_completed_txn_abort(), and
instead re-acquire the actual job's context at the end of the function,
so job_exit() will release the same.
Signed-off-by: Hanna Reitz <hreitz@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <20211006151940.214590-2-hreitz@redhat.com>
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Diffstat (limited to 'python/setup.py')
0 files changed, 0 insertions, 0 deletions