diff options
| author | Markus Armbruster <armbru@redhat.com> | 2023-09-28 15:20:08 +0200 |
|---|---|---|
| committer | Juan Quintela <quintela@redhat.com> | 2023-10-11 11:17:04 +0200 |
| commit | f3805964f8cd79a534c20dfc95ed3000145a5d82 (patch) | |
| tree | 084ad0ffd955c139c1da47de0f7965da03d720ca /python/qemu/machine/machine.py | |
| parent | 446e559c433184b797bf3f3e1b4366c908a4fb6d (diff) | |
| download | qemu-f3805964f8cd79a534c20dfc95ed3000145a5d82.zip qemu-f3805964f8cd79a534c20dfc95ed3000145a5d82.tar.gz qemu-f3805964f8cd79a534c20dfc95ed3000145a5d82.tar.bz2 | |
migration/rdma: Convert qemu_rdma_post_send_control() to Error
Functions that use an Error **errp parameter to return errors should
not also report them to the user, because reporting is the caller's
job. When the caller does, the error is reported twice. When it
doesn't (because it recovered from the error), there is no error to
report, i.e. the report is bogus.
qemu_rdma_exchange_send() violates this principle: it calls
error_report() via qemu_rdma_post_send_control(). I elected not to
investigate how callers handle the error, i.e. precise impact is not
known.
Clean this up by converting qemu_rdma_post_send_control() to Error.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230928132019.2544702-43-armbru@redhat.com>
Diffstat (limited to 'python/qemu/machine/machine.py')
0 files changed, 0 insertions, 0 deletions