diff options
| author | Markus Armbruster <armbru@redhat.com> | 2023-09-28 15:20:03 +0200 |
|---|---|---|
| committer | Juan Quintela <quintela@redhat.com> | 2023-10-11 11:17:04 +0200 |
| commit | 3765ec1f432065e451fe86c54b93fc19a49f0cf4 (patch) | |
| tree | 719e3fb97b7ad5af9603ec2843c2125da415aab7 /python/qemu/machine/machine.py | |
| parent | c4c78dce0b5ebf28c2b54a79905e44f47544aeee (diff) | |
| download | qemu-3765ec1f432065e451fe86c54b93fc19a49f0cf4.zip qemu-3765ec1f432065e451fe86c54b93fc19a49f0cf4.tar.gz qemu-3765ec1f432065e451fe86c54b93fc19a49f0cf4.tar.bz2 | |
migration/rdma: Convert qemu_rdma_exchange_get_response() to Error
Functions that use an Error **errp parameter to return errors should
not also report them to the user, because reporting is the caller's
job. When the caller does, the error is reported twice. When it
doesn't (because it recovered from the error), there is no error to
report, i.e. the report is bogus.
qemu_rdma_exchange_send() and qemu_rdma_exchange_recv() violate this
principle: they call error_report() via
qemu_rdma_exchange_get_response(). I elected not to investigate how
callers handle the error, i.e. precise impact is not known.
Clean this up by converting qemu_rdma_exchange_get_response() to
Error.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Li Zhijian <lizhijian@fujitsu.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230928132019.2544702-38-armbru@redhat.com>
Diffstat (limited to 'python/qemu/machine/machine.py')
0 files changed, 0 insertions, 0 deletions