diff options
author | Alexey Kardashevskiy <aik@ozlabs.ru> | 2021-07-08 16:56:25 +1000 |
---|---|---|
committer | David Gibson <david@gibson.dropbear.id.au> | 2021-07-09 10:55:11 +1000 |
commit | 21bde1ecb6cecba1d2f0219a1b79c240bed78749 (patch) | |
tree | c24f3da40cfb0665e51c6430abd963331262bb5e /pc-bios/vof/main.c | |
parent | 89bb5a4dfdef8316e840ab090ef04a5b7117731b (diff) | |
download | qemu-21bde1ecb6cecba1d2f0219a1b79c240bed78749.zip qemu-21bde1ecb6cecba1d2f0219a1b79c240bed78749.tar.gz qemu-21bde1ecb6cecba1d2f0219a1b79c240bed78749.tar.bz2 |
spapr: Fix implementation of Open Firmware client interface
This addresses the comments from v22.
The functional changes are (the VOF ones need retesting with Pegasos2):
(VOF) setprop will start failing if the machine class callback
did not handle it;
(VOF) unit addresses are lowered in path_offset();
(SPAPR) /chosen/bootargs is initialized from kernel_cmdline if
the client did not change it.
Fixes: 5c991e5d4378 ("spapr: Implement Open Firmware client interface")
Cc: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Message-Id: <20210708065625.548396-1-aik@ozlabs.ru>
Tested-by: BALATON Zoltan <balaton@eik.bme.hu>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Diffstat (limited to 'pc-bios/vof/main.c')
-rw-r--r-- | pc-bios/vof/main.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/pc-bios/vof/main.c b/pc-bios/vof/main.c index 9fc30d2..0f0f6b4 100644 --- a/pc-bios/vof/main.c +++ b/pc-bios/vof/main.c @@ -6,7 +6,7 @@ void do_boot(unsigned long addr, unsigned long _r3, unsigned long _r4) register unsigned long r4 __asm__("r4") = _r4; register unsigned long r5 __asm__("r5") = (unsigned long) _prom_entry; - ((client *)(uint32_t)addr)(); + ((void (*)(void))(uint32_t)addr)(); } void entry_c(void) |