diff options
| author | Thomas Huth <thuth@redhat.com> | 2021-05-02 13:49:20 +0200 |
|---|---|---|
| committer | Thomas Huth <thuth@redhat.com> | 2021-05-09 18:19:43 +0200 |
| commit | 679196a646c91b8ce9a97b0aa81ffb3776cf8046 (patch) | |
| tree | 38aa549ed988145dac2c1ec12f44de9ac9392976 /pc-bios/s390-ccw | |
| parent | b460a220872c28a8da95cbc7e9369d26aa268848 (diff) | |
| download | qemu-679196a646c91b8ce9a97b0aa81ffb3776cf8046.zip qemu-679196a646c91b8ce9a97b0aa81ffb3776cf8046.tar.gz qemu-679196a646c91b8ce9a97b0aa81ffb3776cf8046.tar.bz2 | |
pc-bios/s390-ccw: Silence warning from Clang by marking panic() as noreturn
When compiling the s390-ccw bios with Clang, the compiler emits a warning:
pc-bios/s390-ccw/main.c:210:5: warning: variable 'found' is used uninitialized
whenever switch default is taken [-Wsometimes-uninitialized]
default:
^~~~~~~
pc-bios/s390-ccw/main.c:214:16: note: uninitialized use occurs here
IPL_assert(found, "Boot device not found\n");
^~~~~
It's a false positive, it only happens because Clang is not smart enough
to see that the panic() function in the "default:" case can never return.
Anyway, let's explicitely mark panic() with "noreturn" to shut up the
warning.
Message-Id: <20210502174836.838816-2-thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
Diffstat (limited to 'pc-bios/s390-ccw')
| -rw-r--r-- | pc-bios/s390-ccw/s390-ccw.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/pc-bios/s390-ccw/s390-ccw.h b/pc-bios/s390-ccw/s390-ccw.h index 6cd9266..79db69f 100644 --- a/pc-bios/s390-ccw/s390-ccw.h +++ b/pc-bios/s390-ccw/s390-ccw.h @@ -89,6 +89,7 @@ bool menu_is_enabled_enum(void); #define MAX_BOOT_ENTRIES 31 +__attribute__ ((__noreturn__)) static inline void panic(const char *string) { sclp_print(string); |