aboutsummaryrefslogtreecommitdiff
path: root/os-win32.c
diff options
context:
space:
mode:
authorChristophe Fergeau <cfergeau@redhat.com>2016-10-28 16:48:40 +0200
committerGerd Hoffmann <kraxel@redhat.com>2016-12-05 09:37:52 +0100
commit6c7565028c272c4c6f2a83c3a90b044eeaf2804a (patch)
tree705db07c385b8b95b2c64f468bba96c051731f2d /os-win32.c
parentbd8ef5060dd2124a54578241da9a572faf7658dd (diff)
downloadqemu-6c7565028c272c4c6f2a83c3a90b044eeaf2804a.zip
qemu-6c7565028c272c4c6f2a83c3a90b044eeaf2804a.tar.gz
qemu-6c7565028c272c4c6f2a83c3a90b044eeaf2804a.tar.bz2
qxl: Only emit QXL_INTERRUPT_CLIENT_MONITORS_CONFIG on config changes
Currently if the client keeps sending the same monitor config to QEMU/spice-server, QEMU will always raise a QXL_INTERRUPT_CLIENT_MONITORS_CONFIG regardless of whether there was a change or not. Guest-side (with fedora 25), the kernel QXL KMS driver will also forward the event to user-space without checking if there were actual changes. Next in line are gnome-shell/mutter (on a default f25 install), which will try to reconfigure everything without checking if there is anything to do. Where this gets ugly is that when applying the resolution changes, gnome-shell/mutter will call drmModeRmFB, drmModeAddFB, and drmModeSetCrtc, which will cause the primary surface to be destroyed and recreated by the QXL KMS driver. This in turn will cause the client to resend a client monitors config message, which will cause QEMU to reemit an interrupt with an unchanged monitors configuration, ... This causes https://bugzilla.redhat.com/show_bug.cgi?id=1266484 This commit makes sure that we only emit QXL_INTERRUPT_CLIENT_MONITORS_CONFIG when there are actual configuration changes the guest should act on. Signed-off-by: Christophe Fergeau <cfergeau@redhat.com> Message-id: 20161028144840.18326-1-cfergeau@redhat.com Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Diffstat (limited to 'os-win32.c')
0 files changed, 0 insertions, 0 deletions