aboutsummaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorPooja Dhannawat <dhannawatpooja1@gmail.com>2016-03-28 18:04:11 +0530
committerJason Wang <jasowang@redhat.com>2016-04-06 09:52:07 +0800
commit74044c8ffc10c2cfd76f80c785c3f6a6f101a662 (patch)
tree6b5a2f2ef7d8d1715c55a6e5924426142aace883 /net
parenta1555559ab5bad24fcd1c56fd39284afad8f5af7 (diff)
downloadqemu-74044c8ffc10c2cfd76f80c785c3f6a6f101a662.zip
qemu-74044c8ffc10c2cfd76f80c785c3f6a6f101a662.tar.gz
qemu-74044c8ffc10c2cfd76f80c785c3f6a6f101a662.tar.bz2
net: Allocating Large sized arrays to heap
nc_sendv_compat has a huge stack usage of 69680 bytes approx. Moving large arrays to heap to reduce stack usage. Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Pooja Dhannawat <dhannawatpooja1@gmail.com> Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'net')
-rw-r--r--net/net.c13
1 files changed, 9 insertions, 4 deletions
diff --git a/net/net.c b/net/net.c
index 0bc42a1..f8b1e00 100644
--- a/net/net.c
+++ b/net/net.c
@@ -683,23 +683,28 @@ ssize_t qemu_send_packet_raw(NetClientState *nc, const uint8_t *buf, int size)
static ssize_t nc_sendv_compat(NetClientState *nc, const struct iovec *iov,
int iovcnt, unsigned flags)
{
- uint8_t buf[NET_BUFSIZE];
+ uint8_t *buf = NULL;
uint8_t *buffer;
size_t offset;
+ ssize_t ret;
if (iovcnt == 1) {
buffer = iov[0].iov_base;
offset = iov[0].iov_len;
} else {
+ buf = g_new(uint8_t, NET_BUFSIZE);
buffer = buf;
- offset = iov_to_buf(iov, iovcnt, 0, buf, sizeof(buf));
+ offset = iov_to_buf(iov, iovcnt, 0, buf, NET_BUFSIZE);
}
if (flags & QEMU_NET_PACKET_FLAG_RAW && nc->info->receive_raw) {
- return nc->info->receive_raw(nc, buffer, offset);
+ ret = nc->info->receive_raw(nc, buffer, offset);
} else {
- return nc->info->receive(nc, buffer, offset);
+ ret = nc->info->receive(nc, buffer, offset);
}
+
+ g_free(buf);
+ return ret;
}
ssize_t qemu_deliver_packet_iov(NetClientState *sender,