aboutsummaryrefslogtreecommitdiff
path: root/net
diff options
context:
space:
mode:
authorPrasad J Pandit <pjp@fedoraproject.org>2020-10-21 11:35:50 +0530
committerJason Wang <jasowang@redhat.com>2020-11-11 16:52:23 +0800
commit7564bf7701f00214cdc8a678a9f7df765244def1 (patch)
tree5a1822aa0753c3038b9a9585586515d96e28709b /net
parent2f2fcff323349b6d4ffe00e897f8efb507f071b9 (diff)
downloadqemu-7564bf7701f00214cdc8a678a9f7df765244def1.zip
qemu-7564bf7701f00214cdc8a678a9f7df765244def1.tar.gz
qemu-7564bf7701f00214cdc8a678a9f7df765244def1.tar.bz2
net: remove an assert call in eth_get_gso_type
eth_get_gso_type() routine returns segmentation offload type based on L3 protocol type. It calls g_assert_not_reached if L3 protocol is unknown, making the following return statement unreachable. Remove the g_assert call, it maybe triggered by a guest user. Reported-by: Gaoning Pan <pgn@zju.edu.cn> Signed-off-by: Prasad J Pandit <pjp@fedoraproject.org> Signed-off-by: Jason Wang <jasowang@redhat.com>
Diffstat (limited to 'net')
-rw-r--r--net/eth.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/net/eth.c b/net/eth.c
index 0c1d413..1e0821c 100644
--- a/net/eth.c
+++ b/net/eth.c
@@ -16,6 +16,7 @@
*/
#include "qemu/osdep.h"
+#include "qemu/log.h"
#include "net/eth.h"
#include "net/checksum.h"
#include "net/tap.h"
@@ -71,9 +72,8 @@ eth_get_gso_type(uint16_t l3_proto, uint8_t *l3_hdr, uint8_t l4proto)
return VIRTIO_NET_HDR_GSO_TCPV6 | ecn_state;
}
}
-
- /* Unsupported offload */
- g_assert_not_reached();
+ qemu_log_mask(LOG_UNIMP, "%s: probably not GSO frame, "
+ "unknown L3 protocol: 0x%04"PRIx16"\n", __func__, l3_proto);
return VIRTIO_NET_HDR_GSO_NONE | ecn_state;
}