diff options
| author | Markus Armbruster <armbru@redhat.com> | 2019-08-12 07:23:50 +0200 |
|---|---|---|
| committer | Markus Armbruster <armbru@redhat.com> | 2019-08-16 13:31:52 +0200 |
| commit | db725815985654007ade0fd53590d613fd657208 (patch) | |
| tree | e39bcf77a808fa0002cea415b2a487cf5c7eaf4b /net | |
| parent | dc5e9ac716c5c5312ab29fb9f311f8176064fe04 (diff) | |
| download | qemu-db725815985654007ade0fd53590d613fd657208.zip qemu-db725815985654007ade0fd53590d613fd657208.tar.gz qemu-db725815985654007ade0fd53590d613fd657208.tar.bz2 | |
Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a
recompile of some 5600 out of 6600 objects (not counting tests and
objects that don't depend on qemu/osdep.h). It includes block/aio.h,
which in turn includes qemu/event_notifier.h, qemu/notify.h,
qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h,
qemu/thread.h, qemu/timer.h, and a few more.
Include qemu/main-loop.h only where it's needed. Touching it now
recompiles only some 1700 objects. For block/aio.h and
qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the
others, they shrink only slightly.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20190812052359.30071-21-armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Tested-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Diffstat (limited to 'net')
| -rw-r--r-- | net/can/can_socketcan.c | 1 | ||||
| -rw-r--r-- | net/netmap.c | 1 | ||||
| -rw-r--r-- | net/tap-win32.c | 1 | ||||
| -rw-r--r-- | net/tap.c | 1 |
4 files changed, 4 insertions, 0 deletions
diff --git a/net/can/can_socketcan.c b/net/can/can_socketcan.c index 3dec108..8a6ffad 100644 --- a/net/can/can_socketcan.c +++ b/net/can/can_socketcan.c @@ -27,6 +27,7 @@ #include "qemu/osdep.h" #include "qemu/log.h" +#include "qemu/main-loop.h" #include "qemu/module.h" #include "qapi/error.h" #include "chardev/char.h" diff --git a/net/netmap.c b/net/netmap.c index 0cc8f54..350f097 100644 --- a/net/netmap.c +++ b/net/netmap.c @@ -38,6 +38,7 @@ #include "qapi/error.h" #include "qemu/iov.h" #include "qemu/cutils.h" +#include "qemu/main-loop.h" typedef struct NetmapState { NetClientState nc; diff --git a/net/tap-win32.c b/net/tap-win32.c index 662f9b6..9cdef47 100644 --- a/net/tap-win32.c +++ b/net/tap-win32.c @@ -35,6 +35,7 @@ #include "net/tap.h" /* tap_has_ufo, ... */ #include "sysemu/sysemu.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include <windows.h> #include <winioctl.h> @@ -40,6 +40,7 @@ #include "qemu-common.h" #include "qemu/cutils.h" #include "qemu/error-report.h" +#include "qemu/main-loop.h" #include "qemu/sockets.h" #include "net/tap.h" |