aboutsummaryrefslogtreecommitdiff
path: root/net/l2tpv3.c
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2022-11-04 17:07:00 +0100
committerMarkus Armbruster <armbru@redhat.com>2022-12-14 20:04:47 +0100
commit7480874a69b17000cd10a2f97dbe51580ec44a96 (patch)
tree5a2a339dd854d791b55625c1eeecc4b88e627192 /net/l2tpv3.c
parent9492718b7c00c0a16e2ce834752b8c200e3217d1 (diff)
downloadqemu-7480874a69b17000cd10a2f97dbe51580ec44a96.zip
qemu-7480874a69b17000cd10a2f97dbe51580ec44a96.tar.gz
qemu-7480874a69b17000cd10a2f97dbe51580ec44a96.tar.bz2
qapi net: Elide redundant has_FOO in generated C
The has_FOO for pointer-valued FOO are redundant, except for arrays. They are also a nuisance to work with. Recent commit "qapi: Start to elide redundant has_FOO in generated C" provided the means to elide them step by step. This is the step for qapi/net.json. Said commit explains the transformation in more detail. The invariant violations mentioned there do not occur here. Cc: Jason Wang <jasowang@redhat.com> Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20221104160712.3005652-19-armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> [Fixes for MacOS squashed in]
Diffstat (limited to 'net/l2tpv3.c')
-rw-r--r--net/l2tpv3.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/net/l2tpv3.c b/net/l2tpv3.c
index 350041a..5852e42 100644
--- a/net/l2tpv3.c
+++ b/net/l2tpv3.c
@@ -578,7 +578,7 @@ int net_init_l2tpv3(const Netdev *netdev,
if (l2tpv3->has_udp && l2tpv3->udp) {
s->udp = true;
- if (!(l2tpv3->has_srcport && l2tpv3->has_dstport)) {
+ if (!(l2tpv3->srcport && l2tpv3->dstport)) {
error_setg(errp, "need both src and dst port for udp");
goto outerr;
} else {