aboutsummaryrefslogtreecommitdiff
path: root/net/colo-compare.h
diff options
context:
space:
mode:
authorMarkus Armbruster <armbru@redhat.com>2020-06-30 11:03:47 +0200
committerMarkus Armbruster <armbru@redhat.com>2020-07-02 11:54:47 +0200
commitb40181942e037f74cd12ae7afa140d6508a30639 (patch)
tree697bba3342923614bd5daed34480386a826e487e /net/colo-compare.h
parent475fc97d091c2cbcce0cd48c9fd70e966e5d1159 (diff)
downloadqemu-b40181942e037f74cd12ae7afa140d6508a30639.zip
qemu-b40181942e037f74cd12ae7afa140d6508a30639.tar.gz
qemu-b40181942e037f74cd12ae7afa140d6508a30639.tar.bz2
arm/stm32f205 arm/stm32f405: Fix realize error API violation
The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. stm32f205_soc_realize() and stm32f405_soc_realize() are wrong that way: they pass &err to object_property_set_int() without checking it, and then to qdev_realize(). Harmless, because the former can't actually fail here. Fix by passing &error_abort instead. Cc: Alistair Francis <alistair@alistair23.me> Cc: Peter Maydell <peter.maydell@linaro.org> Cc: qemu-arm@nongnu.org Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Message-Id: <20200630090351.1247703-23-armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Diffstat (limited to 'net/colo-compare.h')
0 files changed, 0 insertions, 0 deletions