diff options
| author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2019-10-04 15:18:20 +0400 |
|---|---|---|
| committer | Paolo Bonzini <pbonzini@redhat.com> | 2019-12-17 19:32:47 +0100 |
| commit | a85d0bf361b8d717a9b15e551a05e3572b20a77e (patch) | |
| tree | 7e64135d0bf7cba10500e27013d07cf4bcb9d294 /monitor | |
| parent | e4f1bea2a8d021b35c5f83035f9af89f5e5bfeef (diff) | |
| download | qemu-a85d0bf361b8d717a9b15e551a05e3572b20a77e.zip qemu-a85d0bf361b8d717a9b15e551a05e3572b20a77e.tar.gz qemu-a85d0bf361b8d717a9b15e551a05e3572b20a77e.tar.bz2 | |
monitor: fix maybe-uninitialized
../monitor/misc.c: In function ‘mon_get_cpu_sync’:
/home/elmarco/src/qq/include/sysemu/hw_accel.h:22:9: error: ‘cpu’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
22 | kvm_cpu_synchronize_state(cpu);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../monitor/misc.c:397:15: note: ‘cpu’ was declared here
397 | CPUState *cpu;
| ^~~
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'monitor')
| -rw-r--r-- | monitor/misc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/monitor/misc.c b/monitor/misc.c index 3baa15f..a74cff3 100644 --- a/monitor/misc.c +++ b/monitor/misc.c @@ -394,7 +394,7 @@ int monitor_set_cpu(int cpu_index) /* Callers must hold BQL. */ static CPUState *mon_get_cpu_sync(bool synchronize) { - CPUState *cpu; + CPUState *cpu = NULL; if (cur_mon->mon_cpu_path) { cpu = (CPUState *) object_resolve_path_type(cur_mon->mon_cpu_path, @@ -411,6 +411,7 @@ static CPUState *mon_get_cpu_sync(bool synchronize) monitor_set_cpu(first_cpu->cpu_index); cpu = first_cpu; } + assert(cpu != NULL); if (synchronize) { cpu_synchronize_state(cpu); } |