diff options
author | Marc-André Lureau <marcandre.lureau@redhat.com> | 2018-12-06 00:37:34 +0400 |
---|---|---|
committer | Markus Armbruster <armbru@redhat.com> | 2018-12-12 09:55:57 +0100 |
commit | a9a0d9b99a347b1413728992726f2bacf76d48ce (patch) | |
tree | 62dd714b48a54106cc53b0584d4f3588fcbf726a /monitor.c | |
parent | 9ac3788b0be368e2826a8e9adadc1ada87d89273 (diff) | |
download | qemu-a9a0d9b99a347b1413728992726f2bacf76d48ce.zip qemu-a9a0d9b99a347b1413728992726f2bacf76d48ce.tar.gz qemu-a9a0d9b99a347b1413728992726f2bacf76d48ce.tar.bz2 |
monitor: check if chardev can switch gcontext for OOB
Not all backends are able to switch gcontext. Those backends cannot
drive a OOB monitor (the monitor would then be blocking on main
thread).
For example, ringbuf, spice, or more esoteric input chardevs like
braille or MUX.
We already forbid MUX because not all frontends are ready to run outside
main loop. Replace that by a context-switching feature check.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20181205203737.9011-5-marcandre.lureau@redhat.com>
[Error condition simplified, commit message adjusted accordingly]
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Diffstat (limited to 'monitor.c')
-rw-r--r-- | monitor.c | 5 |
1 files changed, 3 insertions, 2 deletions
@@ -4562,9 +4562,10 @@ void monitor_init(Chardev *chr, int flags) bool use_oob = flags & MONITOR_USE_OOB; if (use_oob) { - if (CHARDEV_IS_MUX(chr)) { + if (!qemu_chr_has_feature(chr, QEMU_CHAR_FEATURE_GCONTEXT)) { error_report("Monitor out-of-band is not supported with " - "MUX typed chardev backend"); + "%s typed chardev backend", + object_get_typename(OBJECT(chr))); exit(1); } if (use_readline) { |