aboutsummaryrefslogtreecommitdiff
path: root/monitor.c
diff options
context:
space:
mode:
authorJason Wang <jasowang@redhat.com>2015-02-02 15:06:38 +0800
committerStefan Hajnoczi <stefanha@redhat.com>2015-02-06 14:06:45 +0000
commit2c4681f512822b4aa35371683e164d4818f21dce (patch)
tree0c4e1956830b8f63b63d08d0559055cc910f7c30 /monitor.c
parent64a55d60665245174acf6445e0e3f1ec7a53cfe0 (diff)
downloadqemu-2c4681f512822b4aa35371683e164d4818f21dce.zip
qemu-2c4681f512822b4aa35371683e164d4818f21dce.tar.gz
qemu-2c4681f512822b4aa35371683e164d4818f21dce.tar.bz2
monitor: more accurate completion for host_net_remove()
Current completion for host_net_remove will show hub ports and clients that were not peered with hub ports. Fix this. Cc: Luiz Capitulino <lcapitulino@redhat.com> Signed-off-by: Jason Wang <jasowang@redhat.com> Message-id: 1422860798-17495-4-git-send-email-jasowang@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'monitor.c')
-rw-r--r--monitor.c5
1 files changed, 5 insertions, 0 deletions
diff --git a/monitor.c b/monitor.c
index 7e4f605..e6dc50a 100644
--- a/monitor.c
+++ b/monitor.c
@@ -4597,8 +4597,13 @@ void host_net_remove_completion(ReadLineState *rs, int nb_args, const char *str)
count = qemu_find_net_clients_except(NULL, ncs,
NET_CLIENT_OPTIONS_KIND_NIC, 255);
for (i = 0; i < count; i++) {
+ int id;
const char *name;
+ if (ncs[i]->info->type == NET_CLIENT_OPTIONS_KIND_HUBPORT ||
+ net_hub_id_for_client(ncs[i], &id)) {
+ continue;
+ }
name = ncs[i]->name;
if (!strncmp(str, name, len)) {
readline_add_completion(rs, name);