diff options
| author | Markus Armbruster <armbru@redhat.com> | 2023-09-28 15:19:48 +0200 |
|---|---|---|
| committer | Juan Quintela <quintela@redhat.com> | 2023-10-11 11:17:03 +0200 |
| commit | d63f4016b1d154e9ab62e849e6fbb6ded344bcb2 (patch) | |
| tree | 7d0c8defadea640a6a4fe547b90751ea8ee462fe /migration | |
| parent | f35c0d9b0773e3ad143eeaf8d7ef3d4ce85a7e7f (diff) | |
| download | qemu-d63f4016b1d154e9ab62e849e6fbb6ded344bcb2.zip qemu-d63f4016b1d154e9ab62e849e6fbb6ded344bcb2.tar.gz qemu-d63f4016b1d154e9ab62e849e6fbb6ded344bcb2.tar.bz2 | |
migration/rdma: Drop dead qemu_rdma_data_init() code for !@host_port
qemu_rdma_data_init() neglects to set an Error when it fails because
@host_port is null. Fortunately, no caller passes null, so this is
merely a latent bug. Drop the flawed code handling null argument.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
Message-ID: <20230928132019.2544702-23-armbru@redhat.com>
Diffstat (limited to 'migration')
| -rw-r--r-- | migration/rdma.c | 31 |
1 files changed, 14 insertions, 17 deletions
diff --git a/migration/rdma.c b/migration/rdma.c index 0039295..55eb822 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -2767,25 +2767,22 @@ static RDMAContext *qemu_rdma_data_init(const char *host_port, Error **errp) RDMAContext *rdma = NULL; InetSocketAddress *addr; - if (host_port) { - rdma = g_new0(RDMAContext, 1); - rdma->current_index = -1; - rdma->current_chunk = -1; - - addr = g_new(InetSocketAddress, 1); - if (!inet_parse(addr, host_port, NULL)) { - rdma->port = atoi(addr->port); - rdma->host = g_strdup(addr->host); - rdma->host_port = g_strdup(host_port); - } else { - ERROR(errp, "bad RDMA migration address '%s'", host_port); - g_free(rdma); - rdma = NULL; - } - - qapi_free_InetSocketAddress(addr); + rdma = g_new0(RDMAContext, 1); + rdma->current_index = -1; + rdma->current_chunk = -1; + + addr = g_new(InetSocketAddress, 1); + if (!inet_parse(addr, host_port, NULL)) { + rdma->port = atoi(addr->port); + rdma->host = g_strdup(addr->host); + rdma->host_port = g_strdup(host_port); + } else { + ERROR(errp, "bad RDMA migration address '%s'", host_port); + g_free(rdma); + rdma = NULL; } + qapi_free_InetSocketAddress(addr); return rdma; } |