diff options
| author | Dr. David Alan Gilbert <dgilbert@redhat.com> | 2017-08-22 18:02:12 +0100 |
|---|---|---|
| committer | Dr. David Alan Gilbert <dgilbert@redhat.com> | 2017-09-06 14:25:26 +0100 |
| commit | c232bf58cb1169f1bd80c519e2cc4218e525a556 (patch) | |
| tree | 8fc5c74f72587615d6db45a77892a44597587865 /migration | |
| parent | b07d1c2f5607489d4d4a6a65ce36a3e896ac065e (diff) | |
| download | qemu-c232bf58cb1169f1bd80c519e2cc4218e525a556.zip qemu-c232bf58cb1169f1bd80c519e2cc4218e525a556.tar.gz qemu-c232bf58cb1169f1bd80c519e2cc4218e525a556.tar.bz2 | |
migration: Report when bdrv_inactivate_all fails
If the bdrv_inactivate_all fails near the end of the migration,
the migration will fail and often the only diagnostics in the log
are an I/O error which you can't distinguish from an error on
the socket connection.
Add an error so we know when it's actually a block problem.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Message-Id: <20170822170212.27347-1-dgilbert@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Diffstat (limited to 'migration')
| -rw-r--r-- | migration/savevm.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/migration/savevm.c b/migration/savevm.c index fdd15fa..7a55023 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -1157,6 +1157,8 @@ int qemu_savevm_state_complete_precopy(QEMUFile *f, bool iterable_only, * bdrv_invalidate_cache_all() on the other end won't fail. */ ret = bdrv_inactivate_all(); if (ret) { + error_report("%s: bdrv_inactivate_all() failed (%d)", + __func__, ret); qemu_file_set_error(f, ret); return ret; } |