diff options
| author | Fabiano Rosas <farosas@suse.de> | 2024-01-19 20:39:22 -0300 |
|---|---|---|
| committer | Peter Xu <peterx@redhat.com> | 2024-01-29 11:02:12 +0800 |
| commit | 44d0d456d7c40c2f8900b958c01c1a2ef6acf302 (patch) | |
| tree | 1e070e2c61878e26ed1cf5df77051ba99810f364 /migration/savevm.c | |
| parent | 699d9476a065881117004def5c052fbed21f862b (diff) | |
| download | qemu-44d0d456d7c40c2f8900b958c01c1a2ef6acf302.zip qemu-44d0d456d7c40c2f8900b958c01c1a2ef6acf302.tar.gz qemu-44d0d456d7c40c2f8900b958c01c1a2ef6acf302.tar.bz2 | |
migration: Centralize BH creation and dispatch
Now that the migration state reference counting is correct, further
wrap the bottom half dispatch process to avoid future issues.
Move BH creation and scheduling together and wrap the dispatch with an
intermediary function that will ensure we always keep the ref/unref
balanced.
Also move the responsibility of deleting the BH into the wrapper and
remove the now unnecessary pointers.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Link: https://lore.kernel.org/r/20240119233922.32588-6-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
Diffstat (limited to 'migration/savevm.c')
| -rw-r--r-- | migration/savevm.c | 7 |
1 files changed, 1 insertions, 6 deletions
diff --git a/migration/savevm.c b/migration/savevm.c index 9338735..d612c8a 100644 --- a/migration/savevm.c +++ b/migration/savevm.c @@ -2171,10 +2171,7 @@ static void loadvm_postcopy_handle_run_bh(void *opaque) runstate_set(RUN_STATE_PAUSED); } - qemu_bh_delete(mis->bh); - trace_vmstate_downtime_checkpoint("dst-postcopy-bh-vm-started"); - object_unref(OBJECT(migration_get_current())); } /* After all discards we can start running and asking for pages */ @@ -2189,9 +2186,7 @@ static int loadvm_postcopy_handle_run(MigrationIncomingState *mis) } postcopy_state_set(POSTCOPY_INCOMING_RUNNING); - mis->bh = qemu_bh_new(loadvm_postcopy_handle_run_bh, mis); - object_ref(OBJECT(migration_get_current())); - qemu_bh_schedule(mis->bh); + migration_bh_schedule(loadvm_postcopy_handle_run_bh, mis); /* We need to finish reading the stream from the package * and also stop reading anything more from the stream that loaded the |