aboutsummaryrefslogtreecommitdiff
path: root/migration/rdma.c
diff options
context:
space:
mode:
authorJuan Quintela <quintela@redhat.com>2023-05-15 21:57:03 +0200
committerJuan Quintela <quintela@redhat.com>2023-09-29 18:11:21 +0200
commit67c31c9c1af1bb8f7df8275cc8731629e2690f89 (patch)
tree77915d31a56d7d2bd1b0abf41d85af151250eae8 /migration/rdma.c
parentf16ecfa9f9c147168630422a6f4a4c0eddfbe574 (diff)
downloadqemu-67c31c9c1af1bb8f7df8275cc8731629e2690f89.zip
qemu-67c31c9c1af1bb8f7df8275cc8731629e2690f89.tar.gz
qemu-67c31c9c1af1bb8f7df8275cc8731629e2690f89.tar.bz2
migration: Don't abuse qemu_file transferred for RDMA
Just create a variable for it, the same way that multifd does. This way it is safe to use for other thread, etc, etc. Reviewed-by: Leonardo Bras <leobras@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com> Message-Id: <20230515195709.63843-11-quintela@redhat.com>
Diffstat (limited to 'migration/rdma.c')
-rw-r--r--migration/rdma.c22
1 files changed, 20 insertions, 2 deletions
diff --git a/migration/rdma.c b/migration/rdma.c
index a2a3db3..2a3c784 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -2122,9 +2122,18 @@ retry:
return -EIO;
}
+ /*
+ * TODO: Here we are sending something, but we are not
+ * accounting for anything transferred. The following is wrong:
+ *
+ * stat64_add(&mig_stats.rdma_bytes, sge.length);
+ *
+ * because we are using some kind of compression. I
+ * would think that head.len would be the more similar
+ * thing to a correct value.
+ */
stat64_add(&mig_stats.zero_pages,
sge.length / qemu_target_page_size());
-
return 1;
}
@@ -2232,8 +2241,17 @@ retry:
set_bit(chunk, block->transit_bitmap);
stat64_add(&mig_stats.normal_pages, sge.length / qemu_target_page_size());
+ /*
+ * We are adding to transferred the amount of data written, but no
+ * overhead at all. I will asume that RDMA is magicaly and don't
+ * need to transfer (at least) the addresses where it wants to
+ * write the pages. Here it looks like it should be something
+ * like:
+ * sizeof(send_wr) + sge.length
+ * but this being RDMA, who knows.
+ */
+ stat64_add(&mig_stats.rdma_bytes, sge.length);
ram_transferred_add(sge.length);
- qemu_file_credit_transfer(f, sge.length);
rdma->total_writes++;
return 0;