aboutsummaryrefslogtreecommitdiff
path: root/migration/rdma.c
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2017-12-01 17:24:31 -0600
committerPaolo Bonzini <pbonzini@redhat.com>2018-01-16 14:54:52 +0100
commit241187c11818e5223c4bdfac79f28fdf63731733 (patch)
tree7e1a9b80b2412e0f176ad2ba7ba6affdb2d738d4 /migration/rdma.c
parent539022dd6089cdef36589d608ed63cbdaacfd71f (diff)
downloadqemu-241187c11818e5223c4bdfac79f28fdf63731733.zip
qemu-241187c11818e5223c4bdfac79f28fdf63731733.tar.gz
qemu-241187c11818e5223c4bdfac79f28fdf63731733.tar.bz2
tests: Avoid 'do/while(false); ' in vhost-user-bridge
Use of a do/while(0) loop as a way to allow break statements in the middle of execute-once code is unusual. More typical is the use of goto for early exits, with a label at the end of the execute-once code, rather than nesting code in a scope; however, the comment at the end of the existing code makes this alternative a bit unpractical. So, to avoid false positives from a future syntax check about 'while (false);', and to keep the loop form (in case someone ever does add DONTWAIT support, where they can just as easily manipulate the initial loop condition or add an if around the final 'break'), I opted to use the form of a while(1) loop (the break as an early exit is more idiomatic there), coupled with a final break preserving the original comment. Signed-off-by: Eric Blake <eblake@redhat.com> Message-Id: <20171201232433.25193-6-eblake@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Diffstat (limited to 'migration/rdma.c')
0 files changed, 0 insertions, 0 deletions