diff options
author | Juan Quintela <quintela@redhat.com> | 2023-04-11 18:31:20 +0200 |
---|---|---|
committer | Juan Quintela <quintela@redhat.com> | 2023-04-27 16:39:54 +0200 |
commit | 73208a336e249bc8e3bdd76a78d0af7ecaee9178 (patch) | |
tree | f3af835eeb2622e54dcf7148866bd81213a64087 /migration/migration.c | |
parent | 72f8e58707395d24c177ffa9f88a25329638fc98 (diff) | |
download | qemu-73208a336e249bc8e3bdd76a78d0af7ecaee9178.zip qemu-73208a336e249bc8e3bdd76a78d0af7ecaee9178.tar.gz qemu-73208a336e249bc8e3bdd76a78d0af7ecaee9178.tar.bz2 |
migration: Make dirty_bytes_last_sync atomic
As we set its value, it needs to be operated with atomics.
We rename it from remaining to better reflect its meaning.
Statistics always return the real reamaining bytes. This was used to
store how much pages where dirty on the previous generation, so we can
calculate the expected downtime as: dirty_bytes_last_sync /
current_bandwith.
If we use the actual remaining bytes, we would see a very small value
at the end of the iteration.
Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
I am open to use ram_bytes_remaining() in its only use and be more
"optimistic" about the downtime.
Don't use __nocheck() functions.
Use stat64_get() now that it exists.
Diffstat (limited to 'migration/migration.c')
-rw-r--r-- | migration/migration.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/migration/migration.c b/migration/migration.c index 9367bb2..abcadbb 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -2692,7 +2692,8 @@ static void migration_update_counters(MigrationState *s, */ if (stat64_get(&ram_counters.dirty_pages_rate) && transferred > 10000) { - s->expected_downtime = ram_counters.remaining / bandwidth; + s->expected_downtime = + stat64_get(&ram_counters.dirty_bytes_last_sync) / bandwidth; } qemu_file_reset_rate_limit(s->to_dst_file); |