diff options
author | Chrysostomos Nanakos <cnanakos@grnet.gr> | 2014-09-18 14:30:49 +0300 |
---|---|---|
committer | Stefan Hajnoczi <stefanha@redhat.com> | 2014-09-22 11:39:48 +0100 |
commit | 2f78e491d7b46542158ce0b8132ee4e05bc0ade4 (patch) | |
tree | b0bbeff681f1f2910502ecf132cfb96258a350ad /main-loop.c | |
parent | e91a8b2fef92e7d31290e785a35f85a503fa1356 (diff) | |
download | qemu-2f78e491d7b46542158ce0b8132ee4e05bc0ade4.zip qemu-2f78e491d7b46542158ce0b8132ee4e05bc0ade4.tar.gz qemu-2f78e491d7b46542158ce0b8132ee4e05bc0ade4.tar.bz2 |
async: aio_context_new(): Handle event_notifier_init failure
On a system with a low limit of open files the initialization
of the event notifier could fail and QEMU exits without printing any
error information to the user.
The problem can be easily reproduced by enforcing a low limit of open
files and start QEMU with enough I/O threads to hit this limit.
The same problem raises, without the creation of I/O threads, while
QEMU initializes the main event loop by enforcing an even lower limit of
open files.
This commit adds an error message on failure:
# qemu [...] -object iothread,id=iothread0 -object iothread,id=iothread1
qemu: Failed to initialize event notifier: Too many open files in system
Signed-off-by: Chrysostomos Nanakos <cnanakos@grnet.gr>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'main-loop.c')
-rw-r--r-- | main-loop.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/main-loop.c b/main-loop.c index 3cc79f8..53393a4 100644 --- a/main-loop.c +++ b/main-loop.c @@ -126,10 +126,11 @@ void qemu_notify_event(void) static GArray *gpollfds; -int qemu_init_main_loop(void) +int qemu_init_main_loop(Error **errp) { int ret; GSource *src; + Error *local_error = NULL; init_clocks(); @@ -138,8 +139,12 @@ int qemu_init_main_loop(void) return ret; } + qemu_aio_context = aio_context_new(&local_error); + if (!qemu_aio_context) { + error_propagate(errp, local_error); + return -EMFILE; + } gpollfds = g_array_new(FALSE, FALSE, sizeof(GPollFD)); - qemu_aio_context = aio_context_new(); src = aio_get_g_source(qemu_aio_context); g_source_attach(src, NULL); g_source_unref(src); |