diff options
| author | Roman Bolshakov <r.bolshakov@yadro.com> | 2020-07-17 12:35:17 +0300 |
|---|---|---|
| committer | Stefan Hajnoczi <stefanha@redhat.com> | 2020-09-09 17:16:34 +0100 |
| commit | 8c8ed03850208e486f20ee2902435f1c487792e8 (patch) | |
| tree | 8b470a8314c4ee3e4efaa8a43fe62e08908a826b /linux-user | |
| parent | 5e7477bc8222230d0675e643c9f8e385e1e6b503 (diff) | |
| download | qemu-8c8ed03850208e486f20ee2902435f1c487792e8.zip qemu-8c8ed03850208e486f20ee2902435f1c487792e8.tar.gz qemu-8c8ed03850208e486f20ee2902435f1c487792e8.tar.bz2 | |
net/colo: Match is-enabled probe to tracepoint
Build of QEMU with dtrace fails on macOS:
LINK x86_64-softmmu/qemu-system-x86_64
error: probe colo_compare_miscompare doesn't exist
error: Could not register probes
ld: error creating dtrace DOF section for architecture x86_64
The reason of the error is explained by Adam Leventhal [1]:
Note that is-enabled probes don't have the stability magic so I'm not
sure how things would work if only is-enabled probes were used.
net/colo code uses is-enabled probes to determine if other probes should
be used but colo_compare_miscompare itself is not used explicitly.
Linker doesn't include the symbol and build fails.
The issue can be resolved if is-enabled probe matches the actual trace
point that is used inside the test. Packet dump toggle is replaced with
a compile-time conditional definition.
1. http://markmail.org/message/6grq2ygr5nwdwsnb
Fixes: f4b618360e ("colo-compare: add TCP, UDP, ICMP packet comparison")
Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
Cc: Cameron Esfahani <dirty@apple.com>
Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
Reviewed-by: Zhang Chen <chen.zhang@intel.com>
Message-id: 20200717093517.73397-5-r.bolshakov@yadro.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Diffstat (limited to 'linux-user')
0 files changed, 0 insertions, 0 deletions