diff options
| author | Helge Deller <deller@gmx.de> | 2021-02-10 07:12:14 +0100 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2021-02-13 22:50:49 +0100 |
| commit | 78721301138114cf37fb179a6cf73a27c1b3a927 (patch) | |
| tree | 78c884fc45eea91c9993bf559c6fce00f9bec17e /linux-user/hppa | |
| parent | 2bdc74f3d7c4cacb65dbde910471c62992640275 (diff) | |
| download | qemu-78721301138114cf37fb179a6cf73a27c1b3a927.zip qemu-78721301138114cf37fb179a6cf73a27c1b3a927.tar.gz qemu-78721301138114cf37fb179a6cf73a27c1b3a927.tar.bz2 | |
linux-user: fix O_NONBLOCK in signalfd4() and eventfd2() syscalls
On the hppa target userspace binaries may call signalfd4() and
eventfd2() with an old TARGET_O_NONBLOCK value of 000200004 instead of
000200000 for the "mask" syscall parameter, in which case the current
emulation doesn't handle the translation to the native O_NONBLOCK value
correctly.
The 0x04 bit is not masked out before the new O_NONBLOCK bit is set and
as such when calling the native syscall errors out with EINVAL.
Fix this by introducing TARGET_O_NONBLOCK_MASK which is used to mask off
all possible bits. This define defaults to TARGET_O_NONBLOCK when not
defined otherwise, so for all other targets the implementation will
behave as before.
This patch needs to be applied on top of my previous two patches.
Bug was found and patch was verified by using qemu-hppa as debian buildd
server on x86_64.
Signed-off-by: Helge Deller <deller@gmx.de>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
Message-Id: <20210210061214.GA221322@ls3530.fritz.box>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'linux-user/hppa')
| -rw-r--r-- | linux-user/hppa/target_fcntl.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/linux-user/hppa/target_fcntl.h b/linux-user/hppa/target_fcntl.h index 08e3a4f..4eb0ec9 100644 --- a/linux-user/hppa/target_fcntl.h +++ b/linux-user/hppa/target_fcntl.h @@ -9,6 +9,7 @@ #define HPPA_TARGET_FCNTL_H #define TARGET_O_NONBLOCK 000200000 +#define TARGET_O_NONBLOCK_MASK 000200004 /* includes old HP-UX NDELAY flag */ #define TARGET_O_APPEND 000000010 #define TARGET_O_CREAT 000000400 /* not fcntl */ #define TARGET_O_EXCL 000002000 /* not fcntl */ |