diff options
| author | Peter Maydell <peter.maydell@linaro.org> | 2022-07-28 16:14:06 +0100 |
|---|---|---|
| committer | Laurent Vivier <laurent@vivier.eu> | 2022-07-28 19:17:24 +0200 |
| commit | 734a659ad264ac080457167e845ffabbaaa66d0e (patch) | |
| tree | f7651553bbfc3307e4e4d2620e1f652b2aff9d76 /linux-user/flatload.c | |
| parent | 3e4abe2c92964aadd35344a635b0f32cb487fd5c (diff) | |
| download | qemu-734a659ad264ac080457167e845ffabbaaa66d0e.zip qemu-734a659ad264ac080457167e845ffabbaaa66d0e.tar.gz qemu-734a659ad264ac080457167e845ffabbaaa66d0e.tar.bz2 | |
linux-user/flatload.c: Fix setting of image_info::end_code
The flatload loader sets the end_code field in the image_info struct
incorrectly, due to a typo.
This is a very long-standing bug (dating all the way back to when
the bFLT loader was added in 2006), but has gone unnoticed because
(a) most people don't use bFLT binaries
(b) we don't actually do anything with the end_code field, except
print it in debugging traces and pass it to TCG plugins
Fix the typo.
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1119
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20220728151406.2262862-1-peter.maydell@linaro.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Diffstat (limited to 'linux-user/flatload.c')
| -rw-r--r-- | linux-user/flatload.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/linux-user/flatload.c b/linux-user/flatload.c index e4c2f89..e99570c 100644 --- a/linux-user/flatload.c +++ b/linux-user/flatload.c @@ -808,7 +808,7 @@ int load_flt_binary(struct linux_binprm *bprm, struct image_info *info) /* Stash our initial stack pointer into the mm structure */ info->start_code = libinfo[0].start_code; - info->end_code = libinfo[0].start_code = libinfo[0].text_len; + info->end_code = libinfo[0].start_code + libinfo[0].text_len; info->start_data = libinfo[0].start_data; info->end_data = libinfo[0].end_data; info->start_brk = libinfo[0].start_brk; |