aboutsummaryrefslogtreecommitdiff
path: root/job.c
diff options
context:
space:
mode:
authorThomas Huth <thuth@redhat.com>2018-06-26 11:35:40 +0200
committerCornelia Huck <cohuck@redhat.com>2018-07-02 10:37:38 +0200
commit0f0f8b611eeea663c8d3b6021918033e257411a1 (patch)
tree69faeb3be924514248d41a232bf82e439c1da734 /job.c
parent76ed4b18debfe597329d1f6a9eb2ec9ffa751ecd (diff)
downloadqemu-0f0f8b611eeea663c8d3b6021918033e257411a1.zip
qemu-0f0f8b611eeea663c8d3b6021918033e257411a1.tar.gz
qemu-0f0f8b611eeea663c8d3b6021918033e257411a1.tar.bz2
loader: Check access size when calling rom_ptr() to avoid crashes
The rom_ptr() function allows direct access to the ROM blobs that we load during startup. However, there are currently no checks for the size of the accesses, so it's currently possible to crash QEMU for example with: $ echo "Insane in the mainframe" > /tmp/test.txt $ s390x-softmmu/qemu-system-s390x -kernel /tmp/test.txt -append xyz Segmentation fault (core dumped) $ s390x-softmmu/qemu-system-s390x -kernel /tmp/test.txt -initrd /tmp/test.txt Segmentation fault (core dumped) $ echo -n HdrS > /tmp/hdr.txt $ sparc64-softmmu/qemu-system-sparc64 -kernel /tmp/hdr.txt -initrd /tmp/hdr.txt Segmentation fault (core dumped) We need a possibility to check the size of the ROM area that we want to access, thus let's add a size parameter to the rom_ptr() function to avoid these problems. Acked-by: Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by: Thomas Huth <thuth@redhat.com> Message-Id: <1530005740-25254-1-git-send-email-thuth@redhat.com> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
Diffstat (limited to 'job.c')
0 files changed, 0 insertions, 0 deletions