diff options
| author | Max Reitz <mreitz@redhat.com> | 2018-04-21 15:29:22 +0200 |
|---|---|---|
| committer | Max Reitz <mreitz@redhat.com> | 2018-05-15 16:15:21 +0200 |
| commit | 24b7c538fea86b598e2a335f4805a0ab50a30e98 (patch) | |
| tree | 32423583edb4c1cb1a8b92099009252809f4455e /include | |
| parent | 6c6f24fd84895d03baa898bbc4324dd4ccc97071 (diff) | |
| download | qemu-24b7c538fea86b598e2a335f4805a0ab50a30e98.zip qemu-24b7c538fea86b598e2a335f4805a0ab50a30e98.tar.gz qemu-24b7c538fea86b598e2a335f4805a0ab50a30e98.tar.bz2 | |
block: BLK_PERM_WRITE includes ..._UNCHANGED
Currently we never actually check whether the WRITE_UNCHANGED
permission has been taken for unchanging writes. But the one check that
is commented out checks both WRITE and WRITE_UNCHANGED; and considering
that WRITE_UNCHANGED is already documented as being weaker than WRITE,
we should probably explicitly document WRITE to include WRITE_UNCHANGED.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Message-id: 20180421132929.21610-3-mreitz@redhat.com
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/block/block.h | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/include/block/block.h b/include/block/block.h index cdec363..397b5e8 100644 --- a/include/block/block.h +++ b/include/block/block.h @@ -205,6 +205,9 @@ enum { * This permission (which is weaker than BLK_PERM_WRITE) is both enough and * required for writes to the block node when the caller promises that * the visible disk content doesn't change. + * + * As the BLK_PERM_WRITE permission is strictly stronger, either is + * sufficient to perform an unchanging write. */ BLK_PERM_WRITE_UNCHANGED = 0x04, |