diff options
author | Paul Durrant <paul.durrant@citrix.com> | 2019-09-13 09:21:56 +0100 |
---|---|---|
committer | Anthony PERARD <anthony.perard@citrix.com> | 2019-09-24 12:18:47 +0100 |
commit | 374752a26b0ea487dd49c638ee35b97a58ce8e3b (patch) | |
tree | fb774b006d163df618b14c0f72a10ee578210f3a /include | |
parent | df6180bb56cd03949c2c64083da58755fed81a61 (diff) | |
download | qemu-374752a26b0ea487dd49c638ee35b97a58ce8e3b.zip qemu-374752a26b0ea487dd49c638ee35b97a58ce8e3b.tar.gz qemu-374752a26b0ea487dd49c638ee35b97a58ce8e3b.tar.bz2 |
xen / notify: introduce a new XenWatchList abstraction
Xenstore watch call-backs are already abstracted away from XenBus using
the XenWatch data structure but the associated NotifierList manipulation
and file handle registration is still open coded in various xen_bus_...()
functions.
This patch creates a new XenWatchList data structure to allow these
interactions to be abstracted away from XenBus as well. This is in
preparation for a subsequent patch which will introduce separate watch lists
for XenBus and XenDevice objects.
NOTE: This patch also introduces a new notifier_list_empty() helper function
for the purposes of adding an assertion that a XenWatchList is not
freed whilst its associated NotifierList is still occupied.
Signed-off-by: Paul Durrant <paul.durrant@citrix.com>
Reviewed-by: Anthony Perard <anthony.perard@citrix.com>
Message-Id: <20190913082159.31338-2-paul.durrant@citrix.com>
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Diffstat (limited to 'include')
-rw-r--r-- | include/hw/xen/xen-bus.h | 3 | ||||
-rw-r--r-- | include/qemu/notify.h | 2 |
2 files changed, 4 insertions, 1 deletions
diff --git a/include/hw/xen/xen-bus.h b/include/hw/xen/xen-bus.h index 1c2d9df..88b84e2 100644 --- a/include/hw/xen/xen-bus.h +++ b/include/hw/xen/xen-bus.h @@ -14,6 +14,7 @@ typedef void (*XenWatchHandler)(void *opaque); +typedef struct XenWatchList XenWatchList; typedef struct XenWatch XenWatch; typedef struct XenEventChannel XenEventChannel; @@ -63,7 +64,7 @@ typedef struct XenBus { BusState qbus; domid_t backend_id; struct xs_handle *xsh; - NotifierList watch_notifiers; + XenWatchList *watch_list; XenWatch *backend_watch; } XenBus; diff --git a/include/qemu/notify.h b/include/qemu/notify.h index a3d73e4..bcfa70f 100644 --- a/include/qemu/notify.h +++ b/include/qemu/notify.h @@ -40,6 +40,8 @@ void notifier_remove(Notifier *notifier); void notifier_list_notify(NotifierList *list, void *data); +bool notifier_list_empty(NotifierList *list); + /* Same as Notifier but allows .notify() to return errors */ typedef struct NotifierWithReturn NotifierWithReturn; |