diff options
| author | Emanuele Giuseppe Esposito <eesposit@redhat.com> | 2023-01-13 21:42:01 +0100 |
|---|---|---|
| committer | Kevin Wolf <kwolf@redhat.com> | 2023-02-01 16:52:32 +0100 |
| commit | 09d9fc97f8b0bf30f3c55a5ae3a20f799fd3e5f2 (patch) | |
| tree | eb670ff964eaccb9bf8556c943f89d17e731c74d /include/sysemu | |
| parent | 8f4974543203bd1e3a77f198ebb2c60d177b1c40 (diff) | |
| download | qemu-09d9fc97f8b0bf30f3c55a5ae3a20f799fd3e5f2.zip qemu-09d9fc97f8b0bf30f3c55a5ae3a20f799fd3e5f2.tar.gz qemu-09d9fc97f8b0bf30f3c55a5ae3a20f799fd3e5f2.tar.bz2 | |
block: Convert bdrv_io_unplug() to co_wrapper
BlockDriver->bdrv_io_unplug is categorized as IO callback, and it
currently doesn't run in a coroutine. We should let it take a graph
rdlock since the callback traverses the block nodes graph, which however
is only possible in a coroutine.
The only caller of this function is blk_io_unplug(), therefore make
blk_io_unplug() a co_wrapper, so that we're always running in a
coroutine where the lock can be taken.
Signed-off-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230113204212.359076-4-kwolf@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Diffstat (limited to 'include/sysemu')
| -rw-r--r-- | include/sysemu/block-backend-io.h | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/include/sysemu/block-backend-io.h b/include/sysemu/block-backend-io.h index f3736d1..0d432cc 100644 --- a/include/sysemu/block-backend-io.h +++ b/include/sysemu/block-backend-io.h @@ -77,7 +77,9 @@ int blk_get_max_hw_iov(BlockBackend *blk); void coroutine_fn blk_co_io_plug(BlockBackend *blk); void co_wrapper blk_io_plug(BlockBackend *blk); -void blk_io_unplug(BlockBackend *blk); +void coroutine_fn blk_co_io_unplug(BlockBackend *blk); +void co_wrapper blk_io_unplug(BlockBackend *blk); + AioContext *blk_get_aio_context(BlockBackend *blk); BlockAcctStats *blk_get_stats(BlockBackend *blk); void *blk_aio_get(const AIOCBInfo *aiocb_info, BlockBackend *blk, |